Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate WebRTC transport #102

Closed
jackjansen opened this issue May 25, 2023 · 7 comments
Closed

Investigate WebRTC transport #102

jackjansen opened this issue May 25, 2023 · 7 comments
Assignees

Comments

@jackjansen
Copy link
Collaborator

This issue is a placeholder so we have an issue number to create a branch.

@jvdrhoof and @jackjansen will do some experiments to see how we can integrate webrtc as an alternative to socketio/dash/tcp transport.

@jackjansen
Copy link
Collaborator Author

First success. @jvdrhoof has created a Unity project that uses webRTC to transfer webcam streams between two instances.

The Unity project and the webrtc reflector will be put into GitHub repositories and the URLs will be added here.

We continue in July.

@jvdrhoof
Copy link
Collaborator

jvdrhoof commented Jun 1, 2023

Repository available at https://github.com/jvdrhoof/MyWebRTCPlayer

@jackjansen
Copy link
Collaborator Author

Making a lot of progress tonight. Some notes that we shouldn't forget:

  • WebRTCSFU should get a --verbose flag (for normal use: print log output for important events) and a --debug flag (print everything about everything)
  • GoWebRTCPeer should get a --verbose flag (for normal use: print log output for important events) and a --debug flag (print everything about everything)
  • All log messages should be structured (Program: Module: Opened connection to blablablabla)
  • GoWebRTCPeer should be renamed to WebRTCPeer. Maybe all three repos should get a prefix. @jvdrhoof to decide.
  • All three repos should build with CMake.
  • All three repos should use Github actions to build their stuff (and ideally do some limited testing too).
  • All three repos should get a naming convention where built products are stored, and how they are named.

@jackjansen
Copy link
Collaborator Author

jackjansen commented Sep 5, 2023

  • WebRTCSFU needs an index.html that doesn't exist.
  • VR2Gather now gets a URL of some form for webrtc sessions. I think it is in the same place where the Dash URL is, but we need to check to format, and we need to run GoWebRTCPeer with that URL as a parameter.

@jackjansen
Copy link
Collaborator Author

  • Need to add code to AsyncWebRTCWriter (and maybe reader) to check health of peer.
  • Need to kill peer when object disposed.

@jackjansen
Copy link
Collaborator Author

jackjansen commented Sep 6, 2023

  • Need to look at loading and unloading of the DLL.

@jackjansen
Copy link
Collaborator Author

This issue has been superseded by #166

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants