Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

question about using triplet instead of pair of images as training data #7

Open
ConvMech opened this issue Jan 11, 2021 · 4 comments
Open

Comments

@ConvMech
Copy link

Hi,

Thank you again for open-sourcing your training code. When trying to reproduce the training result, I wonder why you choose to use "triplet tuples" rather than "pair of images" for training. Any specific reason for this design?

Looking forward to hearing from you

@jatentaki
Copy link
Collaborator

Please have a look at section 4.Optimization in the paper. In short, this way we get more supervision per detection, since each feature is detected once (incurring unet forward/backward computational costs) and then used in matching twice. This is a perf optimization and I am pretty sure it could be replaced with just slower learning rate/accumulating gradients over more batches if using image pairs.

@ConvMech
Copy link
Author

@jatentaki Thank you for your quick response. I have a follow-up question: looks like when trying to convert the colmap output to the dataset ('pairs': covisible_pairs(images) in colmap2dataset.py), we only generate pairs of images. Could you also share the part where you convert them to the merged dataset.json which uses three images ids tuples as the input?

@poplar1993
Copy link

@jatentaki Thank you for your quick response. I have a follow-up question: looks like when trying to convert the colmap output to the dataset ('pairs': covisible_pairs(images) in colmap2dataset.py), we only generate pairs of images. Could you also share the part where you convert them to the merged dataset.json which uses three images ids tuples as the input?

yes, I have the same question. Do you have solved it ?

@jatentaki
Copy link
Collaborator

Hello, I'm sorry for missing this topic. Unfortunately I don't have the script anymore, but it worked by taking a pair (a, b) and then adding a 3rd image c, sampled uniformly at random from covisible pairs of either a or b (but not necessarily both). I will try to recreate such a script and upload it to the repository but it may not be immediate.

@jatentaki jatentaki reopened this Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants