Initial implementation of azure blob container interface #1853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit b4a9466)
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -49,10 +49,17 @@ | |||
|
|
|||
| // Uploads using a single request. | |||
| uploadSingle(info) { | |||
| let headers = {}; | |||
| if (info.urls[0].includes("blob.core.windows.net")) { | |||
Check failure
Code scanning / CodeQL
Incomplete URL substring sanitization High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 22 days ago
To fix the problem, we need to parse the URL and check the host explicitly rather than using a substring check. This ensures that the host is exactly what we expect and not just a part of a longer, potentially malicious URL.
The best way to fix this is to use the URL class available in modern JavaScript environments to parse the URL and then check the hostname property. We will replace the substring check with a check against a whitelist of allowed hosts.
Suggested changeset
1
ui/src/js/components/inputs/feature/single-upload.js
| @@ -52,3 +52,5 @@ | ||
| let headers = {}; | ||
| if (info.urls[0].includes("blob.core.windows.net")) { | ||
| const url = new URL(info.urls[0]); | ||
| const allowedHosts = ["blob.core.windows.net"]; | ||
| if (allowedHosts.includes(url.hostname)) { | ||
| headers = { |
Copilot is powered by AI and may make mistakes. Always verify output.
jrtcppv
force-pushed
the
dev/1852-azure-blob
branch
from
43ca86d
to
59b45c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.