Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker image build fails for distutils #320

Open
paujar opened this issue Oct 15, 2023 · 3 comments
Open

Docker image build fails for distutils #320

paujar opened this issue Oct 15, 2023 · 3 comments

Comments

@paujar
Copy link

paujar commented Oct 15, 2023

I got this from main branch, is this due some python dependencies that doesn't anymore work?
image

@sarlinpe
Copy link
Member

I don't use Docker so this hasn't been updated for a while. Since we now use the pre-built pycolmap available on pypi, we don't need to depend on the COLMAP Docker image - any other will do.

@scott-vsi
Copy link
Contributor

FYI colmap has begun pushing new images (the previous image was 4 years old and based on colmap 3.6-dev.3). The new image does not have distutils.cmd installed. (distutils is actually deprecated now and was removed in python 3.12). This can be fixed by installing python3.8-distutils:

apt-get update
apt-get install -y python3.8-distutils

However, now colmap/colmap:latest actually has python 3.10 installed. As such, I think these lines could just be removed from the Dockerfile.

@HelgeS
Copy link

HelgeS commented Dec 2, 2023

When removing the lines, it is necessary to install python3-pip. Otherwise pip3 is not found.

Building the docker container without Lines 5-10 and with line 4 changed to RUN apt-get update -y && apt-get install -y python3-pip unzip wget worked for me.

I created pull request #330 to update the Dockerfile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants