Further restrictions on theory rewriters related to safe options #11523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aniemetz
reviewed
Jan 22, 2025
aniemetz
reviewed
Jan 22, 2025
| @@ -593,23 +594,10 @@ void TheoryFp::preRegisterTerm(TNode node) | |||
| } | |||
| if (!options().fp.fpExp) | |||
There was a problem hiding this comment.
Would it make sense to cache the option for faster access?
There was a problem hiding this comment.
I had considered this but I think this may be overkill. Note the same pattern is used in several other theories as well.
aniemetz
reviewed
Jan 22, 2025
aniemetz
reviewed
Jan 22, 2025
src/theory/fp/theory_fp_utils.cpp
Outdated
| @@ -44,6 +46,27 @@ Integer getCardinality(const TypeNode& type) | |||
| * (Integer(2).pow(fps.exponentWidth()) - Integer(1)); | |||
| } | |||
|
|
|||
| void checkExperimentalFloatingPointType(const Node& n) | |||
There was a problem hiding this comment.
I would rename this to either checkFloatingPointType or checkForExperimentalFloatingPointType
Co-authored-by: Aina Niemetz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes cvc5/cvc5-projects#744.
Fixes cvc5/cvc5-projects#745.
Fixes cvc5/cvc5-projects#746.
Fixes cvc5/cvc5-projects#748.
Also makes it so that the FP rewriter does not rewrite experimental FP typed terms unless
fp-expis enabled.Updates several regressions based on this.