Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3rd party code should not exist in this repository. #57

Open
derek-adair opened this issue Sep 6, 2023 · 2 comments
Open

3rd party code should not exist in this repository. #57

derek-adair opened this issue Sep 6, 2023 · 2 comments

Comments

@derek-adair
Copy link

derek-adair commented Sep 6, 2023

Generally speaking it's not a huge issue to do this; I understand the appeal of not requiring a build step for users -- being able to drop this code directly into a ghost instance lowers the bar of entry significantly. However, this generally considered bad practice for a number of reasons.

Instead, the dependencies should be linked w/ npm/yarn/whatever package management tool and the build should be served w/ a "release". Specifically, stuff like FitVids and prism.js should be removed from this repository and linked with npm.

This does add a build step, but is actually a much better experience for contributors and end users will have a succinct build history to download from. If you are interested in incorporating something like this I can submit a pull request. I plan on forking this and adding a couple bells and whistles (gulp to pre-process css/js for example).

@curiositry
Copy link
Owner

Good point @derek-adair! I tend to be a bit old-school :) A pull request would be welcome. Thanks!

@derek-adair
Copy link
Author

I'll gladly do such a thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants