You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Generally speaking it's not a huge issue to do this; I understand the appeal of not requiring a build step for users -- being able to drop this code directly into a ghost instance lowers the bar of entry significantly. However, this generally considered bad practice for a number of reasons.
Instead, the dependencies should be linked w/ npm/yarn/whatever package management tool and the build should be served w/ a "release". Specifically, stuff like FitVids and prism.js should be removed from this repository and linked with npm.
This does add a build step, but is actually a much better experience for contributors and end users will have a succinct build history to download from. If you are interested in incorporating something like this I can submit a pull request. I plan on forking this and adding a couple bells and whistles (gulp to pre-process css/js for example).
The text was updated successfully, but these errors were encountered:
Generally speaking it's not a huge issue to do this; I understand the appeal of not requiring a build step for users -- being able to drop this code directly into a ghost instance lowers the bar of entry significantly. However, this generally considered bad practice for a number of reasons.
Instead, the dependencies should be linked w/ npm/yarn/whatever package management tool and the build should be served w/ a "release". Specifically, stuff like FitVids and prism.js should be removed from this repository and linked with npm.
This does add a build step, but is actually a much better experience for contributors and end users will have a succinct build history to download from. If you are interested in incorporating something like this I can submit a pull request. I plan on forking this and adding a couple bells and whistles (gulp to pre-process css/js for example).
The text was updated successfully, but these errors were encountered: