Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge_group event #77

Open
jkarni opened this issue Aug 23, 2024 · 1 comment
Open

merge_group event #77

jkarni opened this issue Aug 23, 2024 · 1 comment

Comments

@jkarni
Copy link

jkarni commented Aug 23, 2024

Issue description:
The merge_group webhook event seems to be missing. It would be great to have it added.

We're happy to contribute this, if it'd be accepted. It seems like the code is not automatically generated in any way, but that the fixtures are taken from the examples in the GitHub docs?

And thanks for the wonderful library!

@kvanbere
Copy link
Member

kvanbere commented Aug 23, 2024

Hi @jkarni,

Something we noticed early on is that the GitHub documentation is lacking and mostly out of date.

The fixtures are a mixture of GitHub documentation samples, but also real dumps from the actual API (which includes some fields that i.e. didn't exist in the documentation or samples at the time, or in some cases undocumented functionality). It would be nice to have more fixtures and better test coverage - we are open to contributions for this.

You are right, the code is not automatically generated, but the Haskell DSL that we use is very succinct so adding more fields or types is very easy.

The build system is very simple -- to get started, I think all you need to do is clone the repo and run stack build or stack test.

Maybe the most difficult thing here is that we support all platforms and all GHC versions since the library's beginning (7 years ago) but there is extensive CI/CD to help with this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants