Ambiguous step detection - add support to all formatters #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ress' and 'junit,pretty'
# Conflicts: # internal/formatters/fmt_output_test.go
to some_scenarios_including_failing
Go API Changes# github.com/cucumber/godog ## compatible changes Attach: added Attachment: added Attachments: added ErrAmbiguous: added StepAmbiguous: added # github.com/cucumber/godog/formatters ## incompatible changes Formatter.Ambiguous: added # summary Inferred base version: v0.14.1 Suggested version: v0.15.0 |
|
@vearutop - hi - further PR to the "ambiguous" step detection that adds full support to the formatters - as previously we only got to know about dupe steps from the test exit code. |
noodnik2
reviewed
Oct 16, 2024
| errs := "\n\t\t" + strings.Join(matchingExpressions, "\n\t\t") | ||
| return nil, fmt.Errorf("%w, step text: %s\n\tmatches:%s", ErrAmbiguous, text, errs) | ||
| errs := "\n " + strings.Join(matchingExpressions, "\n ") | ||
| return nil, fmt.Errorf("%w, step text: %s\n matches:%s", ErrAmbiguous, text, errs) |
There was a problem hiding this comment.
Cool! I want it. 😊
When will it be released?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Previously "ambiguous" step reporting had been omitted for some of the formatters.
This change adds support for "ambiguous" steps to all formatters.
⚡️ What's your motivation?
Bug fix.
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
Worth scanning the test data file changes - ie "some_scenarios_including_failing"
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.