Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(De)serialize status field as lowercase, as per schema. #335

Merged
merged 4 commits into from
Jun 16, 2024

Conversation

fluxxone
Copy link
Contributor

@fluxxone fluxxone commented May 3, 2024

When running cucumber-html-reporter against a generated json report, I noticed all the steps are classified as skipped. When manually the status to lowercase (Passed -> passed, etc), the report is correctly processed.

I checked out JSON schema linked in the book, which confirms that status is represented in lowercase.

@fluxxone
Copy link
Contributor Author

fluxxone commented May 3, 2024

Manual testing confirmed this solves the issue.

@tyranron tyranron added enhancement Improvement of existing features or bugfix k::api Related to API (application interface) labels Jun 16, 2024
@tyranron tyranron added this to the 0.21.1 milestone Jun 16, 2024
Copy link
Member

@tyranron tyranron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fluxxone thanks! And sorry for the late reaction.

@tyranron tyranron merged commit 3b526f2 into cucumber-rs:main Jun 16, 2024
42 checks passed
@tyranron
Copy link
Member

Released as 0.21.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existing features or bugfix k::api Related to API (application interface)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants