Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct tuple key for width #298

Merged
merged 2 commits into from
Aug 15, 2023

Conversation

Daanoz
Copy link
Contributor

@Daanoz Daanoz commented Aug 15, 2023

Recently we have been experiencing some strange output for our cucumber tests, basically most output was removed during a run. I finally managed to find this only happens when the console height is low. I think this is because the tuple keys are flipped in the changed bit. According to the docs the size_checked returns rows (height) and columns (width)...

@tyranron tyranron added enhancement Improvement of existing features or bugfix k::UI/UX UI (user interface) and UX (user experience) changes labels Aug 15, 2023
@tyranron tyranron modified the milestones: 0.20.0, 0.21.0 Aug 15, 2023
Copy link
Member

@tyranron tyranron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Daanoz wow, nice catch! Thanks!

@tyranron tyranron merged commit de25dfe into cucumber-rs:main Aug 15, 2023
@Daanoz Daanoz deleted the fix/term_width branch August 16, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existing features or bugfix k::UI/UX UI (user interface) and UX (user experience) changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants