Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tracing integration for writer::JUnit and writer::Json (#213) #261

Merged
merged 41 commits into from
Mar 7, 2023
Merged

tracing integration for writer::JUnit and writer::Json (#213) #261

merged 41 commits into from
Mar 7, 2023

Conversation

ilslv
Copy link
Member

@ilslv ilslv commented Mar 1, 2023 •
edited by tyranron
Loading

Synopsis

#258

Solution

Implement tracing integration for the rest of the Writers: writer::JUnit and writer::Json.

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

ilslv added 30 commits February 21, 2023 14:57
@ilslv
WIP
a61b42d
@ilslv
Implement tracing events capturing and postponed output in `writer:…
c063a85 
…:Basic`
@ilslv
Minor corrections
6d9a4d7
@ilslv
Corrections, docs and clippy
1358d55
@ilslv
Add optimisation on PostponedWriter relying on fact, that we get full…
864d1df 
…y formatted messages one-by-one
@ilslv
Forward traces without Scenario Span to all active Scenarios
14af39c
@ilslv
Docs and clippy
200c3b1
@ilslv
Expose tracing public API to Cucumber
ea72445
@ilslv
Corrections
e968140
@ilslv
Corrections
5cc3068
@ilslv
Correct MSRV
1444b28
@ilslv
Merge branch 'main' into 213-tracing-integration
e82d2ee
@ilslv
tracing output test
4d54d6f
@ilslv
Corrections
3f6244d
@ilslv
Corrections
ff44f20
@ilslv
Corrections
915a30a
@ilslv
Corrections
bc323f7
@ilslv
Corrections
140f097
@ilslv
Corrections
7692a15
@ilslv
Corrections
a58cd25
@ilslv
Corrections
7fd71dc
@ilslv
Corrections
317ed7e
@ilslv
Corrections
67005d6
@ilslv
WIP for fixing race between Scenario finishing and logs emitting from…
43f5c20 
… this Scenario
@ilslv
WIP for fixing race between Scenario finishing and logs emitting from…
b080a7a 
… this Scenario
@ilslv
WIP for fixing race between Scenario finishing and logs emitting from…
860f510 
… this Scenario
@ilslv
Corrections
878e8e6
@ilslv
Clippy
42b8202
@ilslv
Clippy
620408e
@ilslv
Clippy
59a83e4
@ilslv ilslv added enhancement Improvement of existing features or bugfix k::design Related to overall design and/or architecture labels Mar 1, 2023
@ilslv ilslv added this to the 0.20.0 milestone Mar 1, 2023
@ilslv ilslv self-assigned this Mar 1, 2023
@ilslv ilslv changed the title Draft: tracing integration for Writers tracing integration for writer::JUnit and writer::Json Mar 2, 2023
@ilslv
Copy link
Member Author

ilslv commented Mar 2, 2023 •
edited
Loading

FCM

Implement `tracing` integration for `writer::JUnit` and `writer::Json` (#261, #213)

- add `embeddings` field to `writer::json::Step` and `writer::json::HookResult`

@ilslv ilslv changed the title tracing integration for writer::JUnit and writer::Json tracing integration for writer::JUnit and writer::Json (#213) Mar 2, 2023
@ilslv ilslv marked this pull request as ready for review March 2, 2023 14:17
@tyranron tyranron linked an issue Mar 3, 2023 that may be closed by this pull request
tracing integration #213
Closed
ilslv added 2 commits March 6, 2023 11:03
@ilslv
Merge branch 'main' into 213-tracing-writer-integrations
8fd6760 
# Conflicts:
#	CHANGELOG.md
#	book/src/output/tracing.md
#	src/event.rs
#	src/future.rs
#	src/runner/basic.rs
#	src/tracing.rs
#	src/writer/basic.rs
#	src/writer/json.rs
#	src/writer/libtest.rs
#	tests/tracing.rs
@ilslv
Corrections
f9f4dfb
@ilslv ilslv requested a review from tyranron March 6, 2023 10:36
@tyranron tyranron added k::UI/UX UI (user interface) and UX (user experience) changes and removed k::design Related to overall design and/or architecture labels Mar 7, 2023
tyranron
tyranron approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@tyranron tyranron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilslv thanks!

@tyranron tyranron added the k::logging Related to library and user logs label Mar 7, 2023
@tyranron tyranron merged commit 63ce040 into main Mar 7, 2023
@tyranron tyranron deleted the 213-tracing-writer-integrations branch March 7, 2023 11:39
@tyranron tyranron mentioned this pull request Mar 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyranron tyranron tyranron approved these changes

Assignees

@ilslv ilslv

Labels
enhancement Improvement of existing features or bugfix k::logging Related to library and user logs k::UI/UX UI (user interface) and UX (user experience) changes
Projects
None yet
Milestone
0.20.0
Development

Successfully merging this pull request may close these issues.

tracing integration
2 participants
@ilslv @tyranron