Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix color=always|never CLI options #253

Merged
merged 2 commits into from
Dec 29, 2022
Merged

Fix color=always|never CLI options #253

merged 2 commits into from
Dec 29, 2022

Conversation

ilslv
Copy link
Member

@ilslv ilslv commented Dec 29, 2022 •
edited by tyranron
Loading

Synopsis

It happens that console::Style uses autodetect for colors.

Solution

Force colors on color=always|never.

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@ilslv ilslv self-assigned this Dec 29, 2022
@ilslv ilslv added enhancement Improvement of existing features or bugfix k::api Related to API (application interface) labels Dec 29, 2022
@ilslv ilslv marked this pull request as ready for review December 29, 2022 10:25
@ilslv
Copy link
Member Author

ilslv commented Dec 29, 2022

FCM

Fix using autodetect for colors on `color=always|never` CLI options (#253)

@ilslv ilslv added this to the 0.19.1 milestone Dec 29, 2022
@ilslv ilslv requested a review from tyranron December 29, 2022 10:49
tyranron
tyranron approved these changes Dec 29, 2022
View reviewed changes
Copy link
Member

@tyranron tyranron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilslv thanks!

@tyranron tyranron merged commit 7ab5a3f into main Dec 29, 2022
@tyranron tyranron deleted the fix-coloring branch December 29, 2022 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyranron tyranron tyranron approved these changes

Assignees

@ilslv ilslv

Labels
enhancement Improvement of existing features or bugfix k::api Related to API (application interface)
Projects
None yet
Milestone
0.19.1
Development

Successfully merging this pull request may close these issues.
2 participants
@ilslv @tyranron