Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass event::ScenarioFinished to after hook handler (#245) #246

Merged
merged 5 commits into from
Nov 23, 2022
Merged

Pass event::ScenarioFinished to after hook handler (#245) #246

merged 5 commits into from
Nov 23, 2022

Conversation

ilslv
Copy link
Member

@ilslv ilslv commented Nov 22, 2022 •
edited by tyranron
Loading

Synopsis

#245

Solution

Pass event::ScenarioFinished to after hook handler.

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@ilslv ilslv added the enhancement Improvement of existing features or bugfix label Nov 22, 2022
@ilslv ilslv added this to the 0.17.0 milestone Nov 22, 2022
@ilslv ilslv self-assigned this Nov 22, 2022
@ilslv
Copy link
Member Author

ilslv commented Nov 22, 2022 •
edited by tyranron
Loading

FCM

Pass `event::ScenarioFinished` to after hook (#246, #245)

Additionally:
- catch panics in user code, when they happen before returned futures are polled

@ilslv ilslv requested a review from tyranron November 22, 2022 14:03
@tyranron tyranron added k::documentation Related to project documentation semver::breaking Represents breaking changes k::api Related to API (application interface) labels Nov 23, 2022
tyranron
tyranron approved these changes Nov 23, 2022
View reviewed changes
Copy link
Member

@tyranron tyranron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilslv thanks!

@tyranron tyranron merged commit ed082b8 into main Nov 23, 2022
@tyranron tyranron deleted the 245-scenario-finish-reason-after-hook branch November 23, 2022 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyranron tyranron tyranron approved these changes

Assignees

@ilslv ilslv

Labels
enhancement Improvement of existing features or bugfix k::api Related to API (application interface) k::documentation Related to project documentation semver::breaking Represents breaking changes
Projects
None yet
Milestone
0.17.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ilslv @tyranron