Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hanging with fail-fast option (#241) #242

Merged
merged 6 commits into from
Nov 9, 2022
Merged

Fix hanging with fail-fast option (#241) #242

merged 6 commits into from
Nov 9, 2022

Conversation

tyranron
Copy link
Member

@tyranron tyranron commented Nov 9, 2022

Fixes #241

Synopsis

#241 (comment)

Solution

  • Consider fail_fast condition when evaluate is_finished condition.
  • Detect fail_fast condition only when there are no retries left.
  • Cover retry and fail-fast conjunction with tests.

@tyranron tyranron added enhancement Improvement of existing features or bugfix k::testing Related to testing and/or automated tests k::refactor Refactoring, technical debt elimination and other improvements of existing code base k::UI/UX UI (user interface) and UX (user experience) changes labels Nov 9, 2022
@tyranron tyranron added this to the 0.16.0 milestone Nov 9, 2022
@tyranron tyranron self-assigned this Nov 9, 2022
@tyranron tyranron merged commit b21d03d into main Nov 9, 2022
@tyranron tyranron deleted the fix-fail-fast branch November 9, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tyranron tyranron

Labels
enhancement Improvement of existing features or bugfix k::refactor Refactoring, technical debt elimination and other improvements of existing code base k::testing Related to testing and/or automated tests k::UI/UX UI (user interface) and UX (user experience) changes
Projects
None yet
Milestone
0.16.0
Development

Successfully merging this pull request may close these issues.

Hangs when used with fail-fast option
1 participant
@tyranron