Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conflicting Ids of CLI arguments #232

Merged
merged 2 commits into from
Oct 12, 2022

Conversation

ilslv
Copy link
Member

@ilslv ilslv commented Oct 12, 2022

Resolves #231

Synopsis

Currently writer::basic::Cli and writer::junit::Cli have argument with conflicting Id: verbose.

Solution

  • Use the same name #[arg(id = "...") and #[arg(name = "..."), as they should be unique due to flattening.
  • Document how to deal with actually overlapping CLI arguments.

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@ilslv ilslv added the enhancement Improvement of existing features or bugfix label Oct 12, 2022
@ilslv ilslv added this to the 0.15.1 milestone Oct 12, 2022
@ilslv ilslv self-assigned this Oct 12, 2022
@ilslv
Copy link
Member Author

ilslv commented Oct 12, 2022

FCM

Fix conflicting `Id`s of CLI options (#232, #231)

- document  in Book how to deal with actually overlapping CLI options

@ilslv
Copy link
Member Author

ilslv commented Oct 12, 2022

Also we should switch from actions-rs to dtolnay's rust-toolchain due to maintenance issues and CI warnings like:

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: actions-rs/toolchain, actions-rs/toolchain

@tyranron
Copy link
Member

@ilslv

Also we should switch from actions-rs to dtolnay's rust-toolchain due to maintenance issues

Let's do this in a separate PR.

@ilslv ilslv requested a review from tyranron October 12, 2022 12:36
@tyranron tyranron force-pushed the 231-fix-conficting-ids-of-cli-args branch from 7b4e87d to a695a53 Compare October 12, 2022 13:38
@tyranron tyranron merged commit f81c556 into main Oct 12, 2022
@tyranron tyranron deleted the 231-fix-conficting-ids-of-cli-args branch October 12, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existing features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple outputs functionality is broken
2 participants