Retry failed Scenarios (#212)
#223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # CHANGELOG.md # README.md # book/src/introduction.md # book/src/output/json.md # book/src/output/junit.md # book/src/output/multiple.md # book/src/quickstart.md # book/src/writing/hooks.md # codegen/CHANGELOG.md # codegen/src/lib.rs # codegen/src/world.rs # src/codegen.rs # src/cucumber.rs # src/lib.rs # src/writer/summarize.rs # tests/after_hook.rs # tests/cli.rs # tests/json.rs # tests/junit.rs # tests/output.rs # tests/wait.rs
ilslv
changed the title
Scenarios (#212)Scenarios (#212)
FCM |
tyranron
requested changes
Aug 19, 2022
src/event.rs
Outdated
|
|
||
| /// [`Scenario`] execution being finished. | ||
| /// | ||
| /// [`Scenario`]: gherkin::Scenario | ||
| Finished, | ||
| Finished(Option<Retries>), |
There was a problem hiding this comment.
@ilslv maybe decomposition would be better here?
pub struct RetryableScenario<World> {
pub event: Scenation<World>,
pub retries: Option<Retries>,
}So we don't pollute the Scenario enum variants with Option.
src/runner/basic.rs
Outdated
| @@ -121,6 +272,7 @@ type Failed = bool; | |||
| pub struct Basic< | |||
| World, | |||
| F = WhichScenarioFn, | |||
| R = RetryOptionsFn, | |||
There was a problem hiding this comment.
@ilslv maybe we could just Box<dyn FnMut> here instead of introducing yet another type parameter? Doesn't seem to be critical.
src/runner/basic.rs
Outdated
|
|
||
| let at = | ||
| rest.strip_prefix(".after").and_then(|after| { | ||
| after.strip_prefix('(').and_then(|after| { |
There was a problem hiding this comment.
@ilslv would be nice to refactor tags parsing into a separate function on RetryOptions, and so cover it with unit tests.
…ailed-tests # Conflicts: # src/event.rs # src/runner/basic.rs
tyranron
approved these changes
Sep 8, 2022
src/writer/summarize.rs
Outdated
| @@ -55,7 +63,7 @@ impl Stats { | |||
| /// [`Step`]: gherkin::Step | |||
| #[must_use] | |||
| pub const fn total(&self) -> usize { | |||
| self.passed + self.skipped + self.failed | |||
| self.passed + self.skipped + self.failed + self.retried | |||
There was a problem hiding this comment.
@ilslv I'm unsure that total should count retried scenarios, which are already part of passed or failed ones. This way we will lie about actual count of steps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #212
Superseeds #214
Synopsis
For now there is no way to retry failed
Scenarios.Solution
Implement ability to implement retries of failed
Scenarios with:@retry/@retry(3)/@retry.after(3s)/@retry(5).after(all)--retry=3/--retry-after=30ms/--retry-after=allChecklist
Draft:prefixDraft:prefix is removed