Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output location of fn that matched the Step #221

Merged
merged 45 commits into from
Jul 25, 2022
Merged

Output location of fn that matched the Step #221

merged 45 commits into from
Jul 25, 2022

Conversation

ilslv
Copy link
Member

@ilslv ilslv commented Jul 12, 2022 •
edited by tyranron
Loading

Synopsis

Often I find myself struggling to find fn, that matched the Step, especially to debug the failure.

Solution

Output step::Location of the fn that matched Step:

  • For every test case in writer::Libtest, in case --show-output option is enabled. Only for failed ones otherwise.
  • Only failed ones inside writer::Basic, writer::Json and writer::Junit

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

ilslv added 18 commits July 7, 2022 11:33
@ilslv
Replace WorldInit macro with World
dd7eeb3
@ilslv
Docs
0f4a869
@ilslv
CHANGELOG
f9f724f
@ilslv
Fix doctest
1ba639b
@ilslv
Remove WorldInit trait and move all of it's methods into the World trait
191c08f
@ilslv
Add event::Cucumber::ParsingFinished variant
0d7c2ac
@ilslv
WIP
7a2ad47
@ilslv
Merge branch 'main' into libtest-format-json
67d0888 
# Conflicts:
#	CHANGELOG.md
#	README.md
#	book/src/introduction.md
#	book/src/output/json.md
#	book/src/output/junit.md
#	book/src/output/multiple.md
#	book/src/quickstart.md
#	book/src/writing/hooks.md
#	codegen/CHANGELOG.md
#	codegen/src/lib.rs
#	codegen/src/world.rs
#	src/codegen.rs
#	src/cucumber.rs
#	src/lib.rs
#	src/writer/summarize.rs
#	tests/after_hook.rs
#	tests/cli.rs
#	tests/json.rs
#	tests/junit.rs
#	tests/output.rs
#	tests/wait.rs
@ilslv
Docs and clean ups
65b5247
@ilslv
Add IntelliJ Rust integration book chapter and CHANGELOG
801c37c
@ilslv
Remove comment
ec2a971
@ilslv
Corrections
207d569
@ilslv
Clippy
916d3e1
@ilslv
Corrections
977bc8a
@ilslv
Docs
bd2ea5e
@ilslv
Corrections
0f87bbe
@ilslv
Add step::Location to event::Step and output it
429dee8
@ilslv
CHANGELOG
5cb8e1b
@ilslv ilslv added enhancement Improvement of existing features or bugfix semver::breaking Represents breaking changes labels Jul 12, 2022
@ilslv ilslv added this to the 0.14.0 milestone Jul 12, 2022
@ilslv ilslv self-assigned this Jul 12, 2022
@ilslv
Copy link
Member Author

ilslv commented Jul 12, 2022 •
edited by tyranron
Loading

FCM

Output location of `fn` matching a `Step` (#221)

Additionally:
- strip `CARGO_MANIFEST_DIR` from output paths whenever is possible

ilslv and others added 14 commits July 15, 2022 15:38
@ilslv
Add commands for creating rust issue [run ci]
4794a6f
@ilslv
Nevermind, already reported [run ci]
78af231
@ilslv
Fix book [run ci]
60be14c
@ilslv
Fix book [run ci]
5c0aca8
@ilslv
Fix book [run ci]
5ba5d17
@tyranron
Merge branch 'main' into libtest-format-json
d48442a
@tyranron
Some corrections [skip ci]
e563633
@ilslv
Corrections [run ci]
fa70d42
@ilslv
Bump async-trait [run ci]
30c9be8
@ilslv
Merge branch 'libtest-format-json' into path-to-matched-step
5de43d6 
# Conflicts:
#	CHANGELOG.md
#	tests/libtest.rs
#	tests/libtest/correct.stdout
@ilslv
Corrections [run ci]
124a73e
@ilslv
Merge branch 'main' into path-to-matched-step
1fd0ee8 
# Conflicts:
#	CHANGELOG.md
#	book/src/output/intellij.md
#	src/writer/discard.rs
#	src/writer/libtest.rs
#	src/writer/mod.rs
#	src/writer/or.rs
#	tests/features/output/background_scenario.feature.out
#	tests/libtest/correct.stdout
@ilslv
Corrections [run ci]
423b80f
@ilslv
Corrections [run ci]
2031bd0
@ilslv ilslv requested a review from tyranron July 21, 2022 13:05
tyranron
tyranron requested changes Jul 22, 2022
View reviewed changes
Copy link
Member

@tyranron tyranron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed in voice:

  1. More clear error output like:

    Step failed
Defined: tests/features/wait/nested/rule.feature:17:7
Matched: tests/wait.rs:47:1

  2. Strip project root dir from .feature path, if possible.

  3. For libtest::Writer with --show-output show path for both .feature file and step function.

  4. Fix duplicated Intellij Rust .gif

@ilslv ilslv requested a review from tyranron July 22, 2022 11:54
tyranron
tyranron requested changes Jul 24, 2022
View reviewed changes
Copy link
Member

@tyranron tyranron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilslv overall implementation is fine now. Just tests need correction.

tests/libtest/correct.stdout Outdated Show resolved Hide resolved
src/writer/libtest.rs Show resolved Hide resolved
src/writer/json.rs Outdated Show resolved Hide resolved
@ilslv ilslv requested a review from tyranron July 25, 2022 08:53
@tyranron tyranron merged commit ba47a18 into main Jul 25, 2022
@tyranron tyranron deleted the path-to-matched-step branch July 25, 2022 09:30
@tyranron tyranron added the k::UI/UX UI (user interface) and UX (user experience) changes label Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyranron tyranron tyranron approved these changes

Assignees

@ilslv ilslv

Labels
enhancement Improvement of existing features or bugfix k::UI/UX UI (user interface) and UX (user experience) changes semver::breaking Represents breaking changes
Projects
None yet
Milestone
0.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ilslv @tyranron