-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support libtest
's format=json
unstable feature (#194, #203, #218)
#220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # CHANGELOG.md # README.md # book/src/introduction.md # book/src/output/json.md # book/src/output/junit.md # book/src/output/multiple.md # book/src/quickstart.md # book/src/writing/hooks.md # codegen/CHANGELOG.md # codegen/src/lib.rs # codegen/src/world.rs # src/codegen.rs # src/cucumber.rs # src/lib.rs # src/writer/summarize.rs # tests/after_hook.rs # tests/cli.rs # tests/json.rs # tests/junit.rs # tests/output.rs # tests/wait.rs
FCM
|
ilslv
changed the title
Draft: Support
Support Jul 11, 2022
libtest
's format=json
unstable feature (#194, #203, #218)libtest
's format=json
unstable feature (#194, #203, #218)
tyranron
requested changes
Jul 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ilslv nice job overall 👍
Though, some stuff is not quite clear, and some needs polishing.
ilslv
commented
Jul 12, 2022
nightly ICE has already been reported. |
tyranron
requested changes
Jul 18, 2022
tyranron
approved these changes
Jul 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ilslv thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #194, #203, #218
Synopsis
By default CLion (and other JB IDEs) pass
-- --format=json -Z unstable-options --show-output
set of flags, which enableslibtest
(default rust test harness)JSON
formatting. Currently this fails the CLI, because those flags are unknown.Solution
Support
JSON
formatting.Default output:
With feature
cargo-json
and-- --format=json
flag:As
libtest
's JSON output first line is:We should somehow know number of test cases. Because of the event streaming nature of this library, to get number of test cases a new event has been added:
event::Cucumber::ParsingFinished
, which is emitted byrunner::Basic
right after allFeatures
are parsed. There are no guarantees on when this event will be emitted, but it should happen exactly once.Checklist
Draft:
prefixDraft:
prefix is removed