Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fail_on_skipped for Background steps #199

Merged
merged 4 commits into from
Jan 19, 2022
Merged

Fix fail_on_skipped for Background steps #199

merged 4 commits into from
Jan 19, 2022

Conversation

rogertorres
Copy link
Contributor

Resolve #198 by including Background steps into the function that converts Skipped steps into Failed ones.

@ilslv ilslv added the enhancement Improvement of existing features or bugfix label Jan 19, 2022
@ilslv
Copy link
Member

ilslv commented Jan 19, 2022 •
edited by tyranron
Loading

FCM

Fix skipped `Background` steps not failing in `writer::FailOnSkipped` (#199, #198)

@ilslv ilslv added this to the 0.11.2 milestone Jan 19, 2022
@ilslv ilslv requested a review from tyranron January 19, 2022 12:04
tyranron
tyranron approved these changes Jan 19, 2022
View reviewed changes
Copy link
Member

@tyranron tyranron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rogertorres thanks! 🍻

@tyranron tyranron merged commit ed3b48d into cucumber-rs:main Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilslv ilslv ilslv left review comments

@tyranron tyranron tyranron approved these changes

Assignees

@rogertorres rogertorres

Labels
enhancement Improvement of existing features or bugfix
Projects
None yet
Milestone
0.11.2
Development

Successfully merging this pull request may close these issues.

Fail background skipped tests
3 participants
@rogertorres @ilslv @tyranron