Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename @allow_skipped built-in tag to @allow.skipped #181

Merged
merged 12 commits into from
Dec 9, 2021
Merged

Rename @allow_skipped built-in tag to @allow.skipped #181

merged 12 commits into from
Dec 9, 2021

Conversation

ilslv
Copy link
Member

@ilslv ilslv commented Dec 7, 2021 •
edited by tyranron
Loading

Synopsis

For now, fixes from gherkin 0.11.1 are tested only inside gherkin crate.

Solution

Test those fixes here too, as this crate ha more robust test suit.

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@ilslv ilslv added the enhancement Improvement of existing features or bugfix label Dec 7, 2021
@ilslv ilslv added this to the 0.11 milestone Dec 7, 2021
@ilslv ilslv self-assigned this Dec 7, 2021
@tyranron
Copy link
Member

tyranron commented Dec 8, 2021

@ilslv 0.11.1 released.

ilslv added 2 commits December 9, 2021 08:25
@ilslv
Merge branch 'main' into gherkin-0.11.1-tests
6c2cf92 
# Conflicts:
#	CHANGELOG.md
#	src/writer/mod.rs
#	src/writer/normalize.rs
@ilslv
Rename @allow_skipped built-in tag to @allow.skipped
9897d9f
@ilslv ilslv changed the title Draft: Cover gherkin 0.11.1 fixes with output tests Draft: Rename @allow_skipped built-in tag to @allow.skipped Dec 9, 2021
@ilslv
Copy link
Member Author

ilslv commented Dec 9, 2021 •
edited by tyranron
Loading

FCM

Rename `@allow_skipped` built-in tag to `@allow.skipped` (#181)

- cover `gherkin` 0.11.1 fixes with tests

@ilslv ilslv changed the title Draft: Rename @allow_skipped built-in tag to @allow.skipped Rename @allow_skipped built-in tag to @allow.skipped Dec 9, 2021
@ilslv ilslv marked this pull request as ready for review December 9, 2021 05:51
@ilslv ilslv requested a review from tyranron December 9, 2021 05:51
@tyranron tyranron merged commit 0c7908e into main Dec 9, 2021
@tyranron tyranron deleted the gherkin-0.11.1-tests branch December 9, 2021 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyranron tyranron tyranron approved these changes

Assignees

@ilslv ilslv

Labels
enhancement Improvement of existing features or bugfix
Projects
None yet
Milestone
0.11
Development

Successfully merging this pull request may close these issues.
2 participants
@ilslv @tyranron