Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge tags from Feature and Rule with Scenario on filtering (#156) #166

Merged
merged 11 commits into from
Nov 26, 2021
Merged

Merge tags from Feature and Rule with Scenario on filtering (#156) #166

merged 11 commits into from
Nov 26, 2021

Conversation

ilslv
Copy link
Member

@ilslv ilslv commented Nov 23, 2021 •
edited by tyranron
Loading

Revealed from #156

Synopsis

Godog and Behave cucumber implementations merge tags from Feature and Rule with Scenario on filtering.

Solution

Follow other implementations and merge tags too.

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@ilslv ilslv added the enhancement Improvement of existing features or bugfix label Nov 23, 2021
@ilslv ilslv added this to the 0.11 milestone Nov 23, 2021
@ilslv ilslv self-assigned this Nov 23, 2021
@ilslv
Copy link
Member Author

ilslv commented Nov 23, 2021

FCM

Merge tags from `Feature` and `Rule` with `Scenario` on filtering with `--tags` CLI option (#166, #156)

ilslv added 2 commits November 23, 2021 15:26
@ilslv
Add FromStr example with cucumber-expressions
8a2feb2
@ilslv
Merge branch 'main' into 156-merge-tags-from-scenario-and-rule-on-fil…
de7f54f 
…tering

# Conflicts:
#	CHANGELOG.md
#	book/src/Features.md
#	book/src/Getting_Started.md
#	codegen/src/attribute.rs
#	codegen/src/lib.rs
#	codegen/tests/example.rs
@ilslv ilslv changed the title Draft: Merge tags from Feature and Rule with Scenario on filtering (#156) Merge tags from Feature and Rule with Scenario on filtering (#156) Nov 26, 2021
@ilslv ilslv marked this pull request as ready for review November 26, 2021 05:15
@ilslv ilslv requested a review from tyranron November 26, 2021 05:16
tyranron
tyranron approved these changes Nov 26, 2021
View reviewed changes
src/tag.rs Outdated
fn eval<I, S>(&self, tags: I) -> bool
where
S: AsRef<str>,
I: Iterator<Item = S> + Clone;
Copy link
Member

@tyranron tyranron Nov 26, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In APIs it's almost always better to accept IntoIterator instead of just an Iterator.

@tyranron tyranron merged commit d577567 into main Nov 26, 2021
@tyranron tyranron deleted the 156-merge-tags-from-scenario-and-rule-on-filtering branch November 26, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyranron tyranron tyranron approved these changes

Assignees

@ilslv ilslv

Labels
enhancement Improvement of existing features or bugfix
Projects
None yet
Milestone
0.11
Development

Successfully merging this pull request may close these issues.
2 participants
@ilslv @tyranron