Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow step implementations to return Result #151

Merged
merged 6 commits into from
Nov 3, 2021

Conversation

benfogle
Copy link
Contributor

@benfogle benfogle commented Nov 2, 2021

Allows step implementations to optionally return a Result. This would be a nice-to-have feature, whose main purpose is to allow writing more concise implementations using the ? operator.

@tyranron tyranron added the enhancement Improvement of existing features or bugfix label Nov 3, 2021
@tyranron tyranron requested a review from ilslv November 3, 2021 08:57
@tyranron
Copy link
Member

tyranron commented Nov 3, 2021

@ilslv please, take a look first, and add some polishing on your decisions.

@tyranron tyranron added this to the 0.11 milestone Nov 3, 2021
Copy link
Member

@ilslv ilslv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benfogle thank you for contributing!

codegen/src/attribute.rs Outdated Show resolved Hide resolved
@ilslv ilslv requested a review from tyranron November 3, 2021 10:44
@ilslv
Copy link
Member

ilslv commented Nov 3, 2021

FCM

Allow step functions to return `Result` (#151)

@tyranron tyranron merged commit ec14003 into cucumber-rs:main Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existing features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants