Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement writer::JUnit (#50) #147

Merged
merged 25 commits into from
Nov 9, 2021
Merged

Implement writer::JUnit (#50) #147

merged 25 commits into from
Nov 9, 2021

Conversation

ilslv
Copy link
Member

@ilslv ilslv commented Oct 29, 2021

Resolves #50

Synopsis

For now cucumber output can't be parsed by default CI tools.

Solution

Implement writer::JUnit

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@ilslv ilslv added the enhancement Improvement of existing features or bugfix label Oct 29, 2021
@ilslv ilslv added this to the 0.11 milestone Oct 29, 2021
@ilslv ilslv self-assigned this Oct 29, 2021
@ilslv ilslv changed the title writer::JUnit (#50) Draft: writer::JUnit (#50) Nov 1, 2021
@ilslv
Copy link
Member Author

ilslv commented Nov 1, 2021

Security audit will be failing until chronotope/chrono#578 is merged

@ilslv
Copy link
Member Author

ilslv commented Nov 1, 2021

Note for future review: to better visualise .xml output I recommend using xunit-viewer

@tyranron
Copy link
Member

tyranron commented Nov 8, 2021

@ilslv junit-report 0.7 is out, so we can finish this.

@ilslv
Copy link
Member Author

ilslv commented Nov 9, 2021

FCM

Implement outputting JUnit XML report (#147, #50)

- impl `writer::JUnit` behind `output-junit` Cargo feature
- make `writer::Basic` generic over `io::Write` implementor

@ilslv ilslv requested a review from tyranron November 9, 2021 05:51
@ilslv ilslv marked this pull request as ready for review November 9, 2021 06:33
@ilslv ilslv changed the title Draft: writer::JUnit (#50) Implement writer::JUnit (#50) Nov 9, 2021
Copy link
Member

@tyranron tyranron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilslv mentioning in Book and in README was missing 😕

}
}

impl<T: io::Write> WriteStr for T {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the parent trait doesn't impose Sized requirement, then using T: ?Sized is very vital in such cases as allows blanket impl to propagate onto trait objects.

@tyranron tyranron merged commit 2e937cb into main Nov 9, 2021
@tyranron tyranron deleted the 50-junit-writer branch November 9, 2021 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existing features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: xunit/junit output
2 participants