-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement writer::JUnit (#50) #147
Conversation
This reverts commit 66996e7.
# Conflicts: # CHANGELOG.md
Security audit will be failing until chronotope/chrono#578 is merged |
Note for future review: to better visualise |
@ilslv |
FCM
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ilslv mentioning in Book and in README was missing 😕
src/writer/out.rs
Outdated
} | ||
} | ||
|
||
impl<T: io::Write> WriteStr for T {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the parent trait doesn't impose Sized
requirement, then using T: ?Sized
is very vital in such cases as allows blanket impl to propagate onto trait objects.
Resolves #50
Synopsis
For now
cucumber
output can't be parsed by defaultCI
tools.Solution
Implement
writer::JUnit
Checklist
Draft:
prefixDraft:
prefix is removed