Restore before and after hooks (#141) #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FCM |
tyranron
changed the title
tyranron
approved these changes
Oct 18, 2021
src/event.rs
Outdated
| /// [`Scenario`]: gherkin::Scenario | ||
| /// [`Step`]: gherkin::Step | ||
| #[derive(Clone, Copy, Debug)] | ||
| pub enum HookTy { |
There was a problem hiding this comment.
In type names it's better not to use shortcuts. They're good for local variables only.
src/event.rs
Outdated
| Failed(Option<Arc<World>>, Info), | ||
| } | ||
|
|
||
| impl fmt::Display for HookTy { |
There was a problem hiding this comment.
Please, do not mix declarations and impls of different types. It's very misleading.
src/event.rs
Outdated
| HookTy::Before => "Before", | ||
| HookTy::After => "After", | ||
| }; | ||
| write!(f, "{}", s) |
There was a problem hiding this comment.
We can just piggyback to Debug impl here.
tests/wait.rs
Outdated
|
|
||
| let err = AssertUnwindSafe(res) | ||
| .catch_unwind() | ||
| .await | ||
| .expect_err("should err"); | ||
| let err = err.downcast_ref::<String>().unwrap(); | ||
|
|
||
| assert_eq!(err, "2 steps failed, 1 parsing error"); | ||
| assert_eq!(err, "2 steps failed, 1 parsing error, 0 hook errors"); |
There was a problem hiding this comment.
Again, it has little sense to write something like "0 errors has happened". We should write about errors only when they really happen.
| @@ -209,6 +219,33 @@ impl Basic { | |||
| } | |||
| } | |||
|
|
|||
| fn hook_failed<W: Debug>( | |||
tyranron
force-pushed
the
return-before-and-after-hooks
branch
from
0199ab6 to
3d30bee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #141
Synopsis
In
0.10.0before and after hooks were removed.Solution
Re-implement them.
Checklist
Draft:prefixDraft:prefix is removedThis PR is nominated at RU RustCon Contest