Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cargo command doesn't fail on skipped step if executed with retries #249

Closed
serzhshakur opened this issue Dec 2, 2022 · 3 comments
Closed

Cargo command doesn't fail on skipped step if executed with retries #249

serzhshakur opened this issue Dec 2, 2022 · 3 comments
Assignees
@ilslv
Labels
bug Something isn't working k::UI/UX UI (user interface) and UX (user experience) changes
Milestone
0.18.0

Comments

@serzhshakur
Copy link

serzhshakur commented Dec 2, 2022 •
edited
Loading

The cargo test command doesn't fail on skipped steps if ran with retries (see picture)

Checkout this repo

The command cargo test --test example -- -n="fail on skipped" will fail with exit code 101
However cargo test --test example -- -n="fail on skipped" --retry=1 will exit with status code 0

Also short summary doesn't mention anything about failing tests.

cucumber__fail_on_skipped
@serzhshakur serzhshakur changed the title Cargo run doesn't fail on skipped step if executed with retries Cargo command doesn't fail on skipped step if executed with retries Dec 2, 2022
@tyranron tyranron added bug Something isn't working k::UI/UX UI (user interface) and UX (user experience) changes labels Dec 2, 2022
@tyranron
Copy link
Member

tyranron commented Dec 2, 2022 •
edited
Loading

@serzhshakur thanks!

@ilslv it seems that runner finishes before the test is retried. Could you look into it?
It's also not the first time when something like this happens (it may be a related bug). We definitely need a rich set of test cases for feature (not Cargo features) combinations (now we test them mostly separately), maybe as a separate PR.

@ilslv ilslv mentioned this issue Dec 7, 2022
Merged
15 tasks
tyranron pushed a commit that referenced this issue Dec 7, 2022
@ilslv
Fix not panicking on fail_on_skipped() with retries (#250, #249)
a585e5a 
- add `NotFound` variant to `event::StepError`
@tyranron tyranron added this to the 0.18.0 milestone Dec 7, 2022
@tyranron
Copy link
Member

tyranron commented Dec 7, 2022

@serzhshakur fixed in #250, released in 0.18.0.

@tyranron tyranron closed this as completed Dec 7, 2022
@serzhshakur
Copy link
Author

thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilslv ilslv

Labels
bug Something isn't working k::UI/UX UI (user interface) and UX (user experience) changes
Projects
None yet
Milestone
0.18.0
Development

No branches or pull requests
3 participants
@tyranron @serzhshakur @ilslv