Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving structopt to clap (clap_derive) #155

Closed
theredfish opened this issue Nov 5, 2021 · 6 comments · Fixed by #188
Closed

Moving structopt to clap (clap_derive) #155

theredfish opened this issue Nov 5, 2021 · 6 comments · Fixed by #188
Assignees
Labels
enhancement Improvement of existing features or bugfix
Milestone

Comments

@theredfish
Copy link
Contributor

Clap recently introduced clap_derive . Would it be ok if I propose a new PR to integrate the changes and move to it?

structop is using clap behind the scene and will be soft-deprecated in favor of clap_derive.

Before proposing a new PR for this I just want to know if this change is ok for you?

@tyranron
Copy link
Member

tyranron commented Nov 5, 2021

@theredfish we've used clap, but intentionally have switched to structopt, because at the moment of our investigation clap_derive lacked support for flattening over type parameters, which we're using to make our CLI composable.

We're going to switch back to clap once it supports that feature.

If you'd like to drive that feature in upstream and then propose a PR here, we would be happy about that!

@theredfish
Copy link
Contributor Author

Oh ok yes definitely! I will keep you updated 👍

@tyranron tyranron added the enhancement Improvement of existing features or bugfix label Nov 5, 2021
@ilslv
Copy link
Member

ilslv commented Nov 17, 2021

structopt-like generics support just got merged, so it looks like we can migrate to clap v3.0.0-beta.6 once it gets released.

@tyranron tyranron added the blocked Blocked for moving on by some condition label Dec 1, 2021
@tyranron
Copy link
Member

tyranron commented Dec 9, 2021

@tyranron tyranron removed the blocked Blocked for moving on by some condition label Dec 9, 2021
@tyranron tyranron added this to the 0.11 milestone Dec 9, 2021
@theredfish
Copy link
Contributor Author

theredfish commented Dec 9, 2021

@ilslv 3.0.0-rc.1 has been released

Do you plan to make the update ? I'm still available to make the update if you want. Let me know

@tyranron
Copy link
Member

@theredfish as we've said before, we would love to see a PR. So, go ahead!

theredfish added a commit to theredfish/cucumber that referenced this issue Dec 12, 2021
theredfish added a commit to theredfish/cucumber that referenced this issue Dec 17, 2021
theredfish added a commit to theredfish/cucumber that referenced this issue Dec 17, 2021
tyranron added a commit that referenced this issue Dec 21, 2021
tyranron added a commit that referenced this issue Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existing features or bugfix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants