Suggestions from Jon via Seb

[aslakhellesoy]

Hi @sebrose @JonJagger - great suggestions from you below:

Hi Seb,
a few notes from my BDD Kickstart attendance...

0. there are a few cases of

require './coordinate'

which is perhaps better as
require_relative 'coordinate'

1. shouty.rb has this...

def shout(person, shout) 
  if (!@shouts.key?(person)) 
    @shouts[person] = [ ] 
  end  
  @shouts[person].push(shout) 
end

I think this would be more idiomatic like this...

def shout(person, shout) 
  @shouts[person] ||= [ ] 
  @shouts[person].push(shout) 
end

2. in shouts_heard_by(hearer)

there are parentheses around the if expression which is unusual.

3. the default is to write rspec assertions in the step-definitions.
   For example...

Then('{word} should hear {word}') do |hearer,shouter|
  expect(can_hear?(hearer,shouter)).to be_truthy
end

I find this slightly wordy. Using plain minitest it is

Then('{word} should hear {word}') do |hearer,shouter|
  assert can_hear?(hearer,shouter)
end

To do this I added (and required) the following env.rb file which seemed to do the trick.

require 'minitest/spec'

class MinitestWorld
  include Minitest::Assertions
  attr_accessor :assertions

  def initialize
    self.assertions = 0
  end
end

World do
  MinitestWorld.new
end

Cheers
Jon