Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EVT-24] Leave x-destination header unchanged when doing a retry #108

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

aymericbouzy
Copy link
Contributor

@aymericbouzy aymericbouzy commented Jan 19, 2021

Context

We have 225 occurences of item events logged with a type * instead of the correct type (example transaction : Datadog)

This is because we analyze x-destination header in the listener.

This is done in various other places in the stack : parcel.* , collect.* , product.* ....

@aymericbouzy aymericbouzy requested a review from getvega January 19, 2021 17:18
Copy link
Contributor

@getvega getvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok this should have no immediate side effect.

There might be one on the replayability of deadletters, which we hardly use today.
Maybe we can add an e2e scenario for that?

The context would be:

  • queue1
  • queue2 (wildcard) => queue2 goes to deadletter
  • deadletter generic queue

steps:

  1. send message that triggers both queues
  2. queue2 should end with a deadletter saved
  3. attempt redeliver of message stacked in deadletter queue
  4. worker behind queue2 should be triggered (and only him)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants