Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless outer parens #3

Open
impredicative opened this issue Jan 7, 2020 · 4 comments
Open

Remove useless outer parens #3

impredicative opened this issue Jan 7, 2020 · 4 comments

Comments

@impredicative
Copy link

impredicative commented Jan 7, 2020

Consider removing the redundant outer parens since all your examples have it. Why can't it just be imputed? Why do I have to remember to type two extra characters that convey zero extra information?

@cube2222
Copy link
Owner

cube2222 commented Jan 7, 2020

You mean trailing parentheses of the whole query? That's actually a great idea! I'll think about how to include this into the grammar.

@impredicative
Copy link
Author

impredicative commented Jan 7, 2020

Yes, the leading and trailing paren of the whole query. I would make it optional, such that the query continues to work either way, with or without the outer parens, assuming this makes sense.

@cube2222
Copy link
Owner

cube2222 commented Jan 7, 2020

There will only ever be a single leading one, but trailing ones are definitely not useful, and were annoying to me too.

Thanks for the issue!

@impredicative
Copy link
Author

impredicative commented Jan 7, 2020

I would remove the requirement of the single leading paren, making it optional. I figure that the program should be able to impute it since all the examples have it. If something is always present, it conveys no information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants