Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thumbnails not maintaining aspect ratio #148

Open
NickLaiacona opened this issue Nov 12, 2024 · 1 comment
Open

Thumbnails not maintaining aspect ratio #148

NickLaiacona opened this issue Nov 12, 2024 · 1 comment
Assignees

Comments

@NickLaiacona
Copy link
Collaborator

The page images do not retain their aspect ratio when displayed as thumbnails. Example:

https://editioncrafter.org/projects/odt/#/ec/passio_verbigenae_f002/g/passio_verbigenae_f002/f/-1/g

@camdendotlol
Copy link
Collaborator

So currently the thumbnail feature figures out which dimensions to require for the thumbnail based on the aspect ratio of the width and height attributes provided by the IIIF manifest. For example, an image that's 2000x1000 will have a thumbnail with dimensions of 130x75.

The manifest in that example (https://cu-mkp.github.io/odt-editioncrafter-data/texts/caryatidum/iiif/manifest.json) says that each item is 800x1000, which is incorrect. The thumbnail display matches the 4:5 aspect ratio.

Did those numbers originally come from a third-party manifest? I'm not sure if this indicates a bug in the CLI app or if it's just bad data from a third-party source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants