Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github actions not updating website on commits #3

Open
njr2128 opened this issue Mar 18, 2024 · 6 comments
Open

github actions not updating website on commits #3

njr2128 opened this issue Mar 18, 2024 · 6 comments

Comments

@njr2128
Copy link
Member

njr2128 commented Mar 18, 2024

when content .md pages are updated either through github interface or pushed from a local repo through command line, the github actions runs, but pages are not being built & deployed (see last commit, eg, a314c6c)

See this run: https://github.com/cu-mkp/dyngleyfamily-editioncrafter-website/actions/runs/8333171340
is this deprecation at fault?

Annotations
1 warning
deploy
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, peaceiris/actions-hugo@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
@tcatapano
Copy link
Member

I realized what was going on after reading the info at https://github.com/cu-mkp/dyngleyfamily-editioncrafter-website/tree/dev?tab=readme-ov-file#to-create-a-website-from-this-repository;

if you only copied the main branch, at this point you should create a new branch called dev. This will have the effect of triggering a workflow that creates the files you'll need to deploy your site to GitHub Pages; those files live in a gh-pages branch, which will be created by the workflow

So, making changes to the files under content in the dev branch will trigger the workflow and update the website which is being served from the gh-pages branch.

@tcatapano
Copy link
Member

To demonstrate, I've made a change to the about.md in the dev branch 0ae3691 which is no appearing in the generated website at https://cu-mkp.github.io/dyngleyfamily-editioncrafter-website/about/

@tcatapano
Copy link
Member

btw, @melissabreynolds to make changes to the transcription, edit the TEI file in the gh-pages branch of the https://github.com/cu-mkp/dyngleyfamily-editioncrafter-data repo, then run the editioncrafter-cli (https://github.com/cu-mkp/editioncrafter-cli) and add/commit/push, which will trigger the publication of that content. We can review the process and help setup editioncrafter-cli if you'd like.

@melissabreynolds
Copy link
Collaborator

Thanks for this info, @tcatapano. I've finally gotten around to creating the "About" and "Introduction" pages for the Dyngley Family site, which I know will need to be updated in the dev branch. I went ahead and made changes in the main branch first, but should I even bother? I thought I might simply create a pull request in the dev branch to merge the two and import my changes in "main" to "dev." Does that sound like a good or bad idea?

@tcatapano
Copy link
Member

@melissabreynolds : I was about to say, yes, make the changes on dev, but I see you've already done that and things are working. Congrats! https://cu-mkp.github.io/dyngleyfamily-editioncrafter-website/introduction/ https://cu-mkp.github.io/dyngleyfamily-editioncrafter-website/about/

@tcatapano
Copy link
Member

We can take on aligning the branches later...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants