Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imageMapster.js has a javascript eval() #71

Open
pbchase opened this issue Sep 1, 2023 · 7 comments
Open

imageMapster.js has a javascript eval() #71

pbchase opened this issue Sep 1, 2023 · 7 comments

Comments

@pbchase
Copy link

pbchase commented Sep 1, 2023

This module fails the REDCap module security scanner with

root@7106e6952520:/var/www/html# ./bin/scan modules/imagemap_v0.0.0/
Running composer install in /var/www/html/redcap_v13.9.3/ExternalModules/

js/imageMapster.js:12 - Please avoid the javascript eval() function. It is not currently possible to ensure its safety via automated scanning.

@123andy, where is this JS file sourced? Can we get an update?

@123andy
Copy link

123andy commented Sep 1, 2023

There are newer versions of ImageMapster -- https://github.com/jamietre/ImageMapster/blob/main/dist/jquery.imagemapster.min.js

I'll create a ticket to update it but it may take a little while to do it and test it... Happy to accept a PR :-)

@ChemiKyle
Copy link

eval still exists in imageMapster.js, but PSALM no longer complains about it.

@dhinostroza
Copy link

https://github.com/jamietre/ImageMapster/blob/main/dist/jquery.imagemapster.min.js v 1.8.0, released May 1, 2024, is working nicely with REDCap v14.3.13. Just rename jquery.imagemapster.min.js to imageMapster.js and replace the file in the imagemap(_v1.12.0)/js folder.

@pbchase
Copy link
Author

pbchase commented Jun 11, 2024

https://github.com/jamietre/ImageMapster/blob/main/dist/jquery.imagemapster.min.js v 1.8.0, released May 1, 2024, is working nicely with REDCap v14.3.13. Just rename jquery.imagemapster.min.js to imageMapster.js and replace the file in the imagemap(_v1.12.0)/js folder.

@dhinostroza care to submit a Pull Request? We'd be happy to test it, merge it, and release it.

@dhinostroza
Copy link

Pull Request sent.

@pbchase
Copy link
Author

pbchase commented Jun 11, 2024

Pull Request sent.

Thanks. I had some issues with it so I assigned the review to @saipavan10-git. I expect you'll get some feedback soon.

@dhinostroza
Copy link

Sorry if I got that Pull Request wrong. It was my first time [blush].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants