Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User-defined mode additions #69

Open
Dave-Code opened this issue Nov 16, 2018 · 4 comments
Open

User-defined mode additions #69

Dave-Code opened this issue Nov 16, 2018 · 4 comments
Assignees
Milestone

Comments

@Dave-Code
Copy link

Wishlist - It would be nice to add new modes like FT8 and JS8. It saves the author from making a new version right away ;-)

@WB5VQX
Copy link
Contributor

WB5VQX commented Feb 17, 2019

Perhaps the modes/submodes could be stored in sqlite table(s) from which the mode/submode combo-boxes would be populated as well as the associated internal lists. However, note that the modes/submodes available are defined by adif.org, so maybe a better solution would be to download the available modes from adif.org on start-up. That would ensure that the latest modes supported by the adif format would be available in pyqso as soon as they are published by adif. I note, that I have not used the cabrillo format and am not aware of any restrictions that may be imposed by this standard.

@ctjacobs
Copy link
Owner

Agreed - I'd like to keep this ADIF-compatible so I'll see if there is a way of reliably downloading and parsing the list of valid modes and submodes from the ADIF website.

@ctjacobs ctjacobs added this to the v1.2.0 milestone Apr 7, 2019
@ctjacobs ctjacobs self-assigned this Apr 7, 2019
@ctjacobs
Copy link
Owner

ctjacobs commented Apr 7, 2019

I've added a script in the new modes-update branch which parses the MODES table on the ADIF website. It works by scraping the webpage of the most recent ADIF version using the BeautifulSoup module. However, if the HTML table ID ("Enumeration_Mode") or the formatting changes in the future then this could break the script.

It might be best to create a separate database in the res (resources) directory containing the current list of modes and submodes. The user can then run the script to update this table if/when desired.

ctjacobs pushed a commit that referenced this issue Apr 14, 2019
@ctjacobs
Copy link
Owner

A new menu item is now available (ADIF > Update Modes) for updating the ADIF modes from the ADIF website. After entering a URL such as http://adif.org/309/ADIF_309.htm, PyQSO will scrape the webpage and parse the modes table to extract the up-to-date list of modes. This still needs to be tested and merged into the main branch, but feel free to give it a try in the mean time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants