-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Extrapolator Utilizing Visible Edges Blending #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RuneDominik
force-pushed
the
ParametrizedVisibleEdgesExtrapolator
branch
from
August 30, 2023 14:11
1a3eeba
to
30ed87d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #253 +/- ##
==========================================
+ Coverage 95.40% 95.60% +0.20%
==========================================
Files 60 62 +2
Lines 3135 3278 +143
==========================================
+ Hits 2991 3134 +143
Misses 144 144 ☔ View full report in Codecov by Sentry. |
RuneDominik
force-pushed
the
ParametrizedVisibleEdgesExtrapolator
branch
2 times, most recently
from
September 1, 2023 13:10
45a0e21
to
05b30ff
Compare
maxnoe
reviewed
Sep 15, 2023
RuneDominik
force-pushed
the
ParametrizedVisibleEdgesExtrapolator
branch
from
November 2, 2023 11:57
05b30ff
to
5fafcd3
Compare
maxnoe
reviewed
Nov 23, 2023
maxnoe
reviewed
Nov 23, 2023
maxnoe
reviewed
Nov 23, 2023
maxnoe
reviewed
Nov 23, 2023
maxnoe
reviewed
Nov 23, 2023
maxnoe
reviewed
Nov 23, 2023
maxnoe
reviewed
Nov 23, 2023
RuneDominik
force-pushed
the
ParametrizedVisibleEdgesExtrapolator
branch
from
November 28, 2023 11:40
5fafcd3
to
88319c2
Compare
RuneDominik
force-pushed
the
ParametrizedVisibleEdgesExtrapolator
branch
from
December 14, 2023 12:56
88319c2
to
ecf4ab9
Compare
maxnoe
reviewed
Jan 18, 2024
maxnoe
reviewed
Jan 18, 2024
maxnoe
reviewed
Jan 18, 2024
maxnoe
reviewed
Jan 18, 2024
maxnoe
reviewed
Jan 18, 2024
RuneDominik
force-pushed
the
ParametrizedVisibleEdgesExtrapolator
branch
from
January 23, 2024 10:25
b00e56e
to
e871e8e
Compare
maxnoe
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
ParametrizedNearestSimplexExtrapolator
, while requiring minimal assumptions, does not result in a smooth extrapolation. Discontinuous results occur where the nearest simplex changes from one to another and with it the used templates. Blending over visible edges [1] solves this but ofc. introduces further assumptions.[1] P. Alfred (1984). Triangular Extrapolation. Technical summary rept., Univ. of Wisconsin-Madison. https://apps.dtic.mil/sti/pdfs/ADA144660.pdf