Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with DQM after refactoring #83

Closed
mdpunch opened this issue Jan 23, 2024 · 2 comments · Fixed by #85
Closed

Problem with DQM after refactoring #83

mdpunch opened this issue Jan 23, 2024 · 2 comments · Fixed by #85
Assignees
Labels
bug Something isn't working

Comments

@mdpunch
Copy link
Contributor

mdpunch commented Jan 23, 2024

Describe the bug

In the version after refactoring (__version__== '0.1.6.dev13+gc4a163d') the command start_dqm.py doesn't work.

To Reproduce
Steps to reproduce the behavior:

  1. activate the nectarchain dev env
  2. try e.g. python ../nectarchain/src//nectarchain/dqm/start_dqm.py -r 4332 $NECTARCAMDATA $NECTARCAMDATA
  3. get error: File "/scr/punch/CTA/NectarCAM_muons/../nectarchain/src//nectarchain/dqm/start_dqm.py", line 53, in <module> from nectarchain.data.container import utils ImportError: cannot import name 'utils' from 'nectarchain.data.container' (/scr/punch/CTA/nectarchain/src/nectarchain/data/container/__init__.py)
  4. Then, start ipython
from nectarchain.data.container import utils
---------------------------------------------------------------------------
ImportError                               Traceback (most recent call last)
Cell In[9], line 1
----> 1 from nectarchain.data.container import utils

ImportError: cannot import name 'utils' from 'nectarchain.data.container' (/scr/punch/CTA/nectarchain/src/nectarchain/data/container/__init__.py)
  1. ... panic ...

Expected behavior
Expect container to be imported correctly

Supporting information

Additional context
@jlenain guesses that this is due to the major refactoring effort.

@mdpunch mdpunch added the bug Something isn't working label Jan 23, 2024
@jlenain jlenain changed the title Problem with DQM after refactoring Problem with DataManagement class after refactoring Jan 23, 2024
@jlenain
Copy link
Collaborator

jlenain commented Jan 23, 2024

Hi @mdpunch ,
Thanks for reporting this!
This is not related to the DQM directly, but on the automatic mechanism to download data from DIRAC, which was in nectarchain.data.container.utils and has been moved into nectarchain.data.management following the code refactoring from #78 and #82 . We'll fix this asap.

@jlenain jlenain self-assigned this Jan 23, 2024
@jlenain jlenain changed the title Problem with DataManagement class after refactoring Problem with DQM after refactoring Jan 23, 2024
@mdpunch
Copy link
Contributor Author

mdpunch commented Jan 23, 2024

Okay, that worked for that bug, thanks... now on to the next one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants