Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use flatfield heuristic flag for data after 2023-10-10? #257

Open
morcuended opened this issue Oct 30, 2023 · 1 comment
Open

Do not use flatfield heuristic flag for data after 2023-10-10? #257

morcuended opened this issue Oct 30, 2023 · 1 comment

Comments

@morcuended
Copy link
Member

Following an email from Seiya from Oct 11th, 2023, it's possible to not using FF heuristic flag to find calibration events for the data taken after Oct 10th, 2023.

This should be changed in the osa cfg and also in the lstchain config file used.

Might be good to analyze a date from past period to check that it is actually working.

@moralejo
Copy link

moralejo commented Oct 30, 2023

Might be good to analyze a date from past period to check that it is actually working.

The data check has a test on that - it verifies which of the heuristically-identified FF have the right flag.

I think this would stop working if you use the identification by flag (all of the "newly-defined" -via flag- FF events will have the flag ON by construction). For osa I would leave it as it is, unless you see any advantage in the change.

@morcuended morcuended changed the title Do not use flatfield heuristic flag for data after 2023-10-10 Do not use flatfield heuristic flag for data after 2023-10-10? Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants