-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need for specific scipy version installation #1093
Comments
Is it possible to install scipy 1.7 with current dependencies? If everything worked with 1.9.3 why did you try 1.8? |
Using scipy 1.7 does work with the current dependencies. I had not noticed any issue with the scipy version in my lst-dev conda environment as there was no error so far, and so I am not sure when 1.9.3 was installed exactly. |
Working with Gammapy, I just know that there was an issue with scipy v1.10, which was resolved in the bugfix scipy v1.10.1. |
SciPy 1.7.0 : Jun 20, 2021 It seems the change of QhullError implementation which is compatible with your way of importing it is implemented since release 1.8.0. So you should add scipy>=1.8 |
It does work and I get scipy 1.9.3 installed and all tests pass. Also checked with the fix in #1092 to be certain. I will make a PR for this change. |
@moralejo found an import error for
QhullError
fromscipy.spatial
from the new merger of PR #711 https://github.com/cta-observatory/cta-lstchain/blob/master/lstchain/high_level/interpolate.py#L21 while having scipy 1.7 installed in the conda environment. We do not have any constraints on scipy version currently. This might be essential for the forthcoming major release with major updated dependencies, to avoid any such issues for individual users.The particular import worked on my system which has scipy 1.9.3 and it also did not create any warnings for this import in the CI.
I tried to use
scipy~=1.8
but it had various inconsistencies with a list of other dependencies (pydantic, ctapipe, gammapy, iminuit, etc). With this change, it allows me to make the above import ofQhullError
but the issue with other dependencies is a problem.The text was updated successfully, but these errors were encountered: