Skip to content
This repository has been archived by the owner on Feb 26, 2021. It is now read-only.

Better caching #55

Open
cstjean opened this issue Oct 8, 2017 · 2 comments
Open

Better caching #55

cstjean opened this issue Oct 8, 2017 · 2 comments

Comments

@cstjean
Copy link
Owner

cstjean commented Oct 8, 2017

@timholy Revise.jl achieves speed by mutating data structures, but TraceCalls.jl achieves it by memoizing function results. I already found out the hard way that this is a dangerous mix. Can I assume that the Expr objects in Revise.module2files won't be mutated by subsequent revise calls?

@timholy
Copy link

timholy commented Oct 8, 2017

module2files just holds a list of dependent files. Do you mean file2modules? (Yes, it's hard keeping track of the names.) I don't think so. If you revise a file, the expressions in file2modules get replaced by their new values.

@cstjean
Copy link
Owner Author

cstjean commented Oct 8, 2017

Ok, that's also what I understood from the code. Thank you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants