Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong restructuring of height in class and element selectors #411

Closed
accetone opened this issue Dec 3, 2019 · 3 comments
Closed

Wrong restructuring of height in class and element selectors #411

accetone opened this issue Dec 3, 2019 · 3 comments

Comments

@accetone
Copy link

accetone commented Dec 3, 2019

Please check following input and output. Class layout will have height: 60px which is incorrect.

Input

html {
  width: 100%;
  height: 100%;
  margin: 0;
}

.header {
  width: 100%;
  height: 60px;
}

.layout {
  width: 100%;
  height: 100%;
  margin: 0;
  padding: 0;
}

Output

.layout,
html {
  height: 100%;
  margin: 0
}

html {
  width: 100%
}

.header,
.layout {
  width: 100%;
  height: 60px
}

.layout {
  padding: 0
}
@charlessuh
Copy link
Contributor

charlessuh commented Jan 7, 2020

@accetone I've taken a stab at a fix as a user myself. Does the following output look correct before I open a PR?

html {
    width: 100%
}

.header,.layout {
    width: 100%;
    height: 60px
}

.layout,html {
    height: 100%;
    margin: 0
}

.layout {
    padding: 0
}

@accetone
Copy link
Author

accetone commented Jan 7, 2020

@charlessuh thanks, your output look correct.

@lahmatiy
Copy link
Member

Fix published in 4.0.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants