Nix: False positives in E2E tests

[koxu1996]

Nix's e2e tests relying on curl SHOULD be already broken at least twice - for example the following PRs successfully passed CI checks, even they changed request body in incompatible way:

• Replace PublicKey and Signature with plain Vec<u8> #32
• Integrate ASN.1 transaction format with server #53

[koxu1996]

By default, receiving a 500 Internal Server Error would result in an exit code of 0 (indicating no error in the curl command itself). In order to detect server errors, --fail / --fail-with-body should be provided.

@marijanp already submitted fix in #59.

[koxu1996]

CI checks fixed in #59.

[marijanp]

By default, receiving a 500 Internal Server Error would result in an exit code of 0 (indicating no error in the curl command itself). In order to detect server errors, --fail / --fail-with-body should be provided.

@marijanp already submitted fix in #59.

Curl didn't respond with a 500 error code because our server was beghind an nginx server, which returned a html containing a 301 permamently moved error message. This returns a 0 exit code.

[koxu1996]

@marijanp You are wrong 🙄. Here is proof that code 301 is not an error, even if you add --fail-with-body:

$ curl --fail-with-body -v bankier.pl
*   Trying 104.22.72.129:80...
* Connected to bankier.pl (104.22.72.129) port 80
> GET / HTTP/1.1
> Host: bankier.pl
> User-Agent: curl/8.4.0
> Accept: */*
>
< HTTP/1.1 301 Moved Permanently
< Date: Thu, 04 Apr 2024 12:14:44 GMT
< Transfer-Encoding: chunked
< Connection: keep-alive
< Cache-Control: max-age=3600
< Expires: Thu, 04 Apr 2024 13:14:44 GMT
< Location: https://bankier.pl/
< Server: cloudflare
< CF-RAY: 86f1384afb448869-WAW
<
* Connection #0 to host bankier.pl left intact
$ echo $?
0

Also, I didn't say server returned code 500, but only stated that error checking was done incorrectly:

receiving a 500 Internal Server Error WOULD result in an exit code of 0

[marijanp]

@koxu1996 so what is wrong about my statement? I said it returned 0, because curl fetched a 301. A 0 indicates success.

[koxu1996]

@marijanp Wrong CI checks were fixed by adding --fail-with-body, and code 301 is completely unrelated to this issue.

[koxu1996]

Maybe you are suggesting there is another CI issue?

[marijanp]

There were two issues, another one was that I forced SSL in our production config. And I had to override that in the test to get rid of the permament/y moved 301 status code. That's the first reason it didn't error.

[marijanp]

So even adding --fail-with-body was not the only problem with it:

[marijanp]

4e61d68

[koxu1996]

Like I said, another CI issue - not related with curl and fixed without context.