Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling / Formatting #21

Open
SamKomesarook opened this issue Oct 19, 2021 · 6 comments
Open

Styling / Formatting #21

SamKomesarook opened this issue Oct 19, 2021 · 6 comments

Comments

@SamKomesarook
Copy link

Would it be possible to add some sort of formatting on command or save to this plugin? I'm happy to work on this, just not sure of the contributing guidelines...

@stekyne
Copy link
Member

stekyne commented Oct 19, 2021

https://code.visualstudio.com/api/language-extensions/programmatic-language-features#format-source-code-in-an-editor

Yeah it's definitely possible. Would be great to get some kind of formatting working.

@SamKomesarook
Copy link
Author

I was thinking the following points:

  • Spacing between args in the score and instrs
  • Align tabs in rows of opcodes
  • Spacing between constants/flags

@stekyne
Copy link
Member

stekyne commented Oct 19, 2021

It sounds reasonable. I'd say it'll be easier to get consensus when there is something to see. It should be easy to tweak after anyways.

@SamKomesarook
Copy link
Author

Gucci, could I work on this one? Any specific contributing guidelines?

@kunstmusik
Copy link
Member

@SamKomesarook There aren't specific guidelines specified (though, perhaps we should add one; suggestions appreciated). I think feel free to fork and submit a PR when ready and we can review the PR and merge. Thanks!

@SamKomesarook
Copy link
Author

#22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants