Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suspected typo in Chapter 1 #302

Open
michaelosheaa opened this issue Jun 13, 2021 · 6 comments
Open

Suspected typo in Chapter 1 #302

michaelosheaa opened this issue Jun 13, 2021 · 6 comments

Comments

@michaelosheaa
Copy link

michaelosheaa commented Jun 13, 2021

I noticed in Line 76 of Chapter 1 the sentence: "It is well known that R code can promote algorithmic efficiency compared with low level languages for certain tasks, especially if the code was written by someone who doesn't fully understand the language."

  • Should this instead be "algorithmic inefficiency"?
@Robinlovelace
Copy link
Collaborator

Hi @michaelosheaa yes I think that is a typo! Fix would be most welcome, thanks for pointing this out.

@shafayetShafee
Copy link
Contributor

@Robinlovelace , can I make a pull request to fix this typo 😄?

@Robinlovelace
Copy link
Collaborator

Hi @shafayetShafee yes of course, that would be most welcome. Many thanks!

@shafayetShafee
Copy link
Contributor

@Robinlovelace, hey I am noticing that this typo still exists in the online version of the book, although I have corrected it and PR got merged. Did I miss something? Sorry if I did something wrong 😓!

@Robinlovelace
Copy link
Collaborator

No that is probably an issue with the build process. Can you help @csgillespie ?

@csgillespie
Copy link
Owner

This is going to be tricky. It was originally set up via .travis many, many years ago. Converting to GitHub Actions is going to take a little time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants