Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CS50p watch.py passes check50 if regex looks for quotes around link #300

Open
niktss opened this issue Dec 12, 2024 · 0 comments
Open

CS50p watch.py passes check50 if regex looks for quotes around link #300

niktss opened this issue Dec 12, 2024 · 0 comments

Comments

@niktss
Copy link

niktss commented Dec 12, 2024

For cs50/problems/2022/python/watch, having a regex like r"\"http(?:s)?://(?:www.)?youtube.com/embed/(?P<vid_id>\w+)\"" shows check50 passing all tests, but the exercise calls for

extracts any YouTube URL that’s the value of a src attribute of an iframe element therein

and the check50 test itself is called "watch.py returns None when given YouTube link outside of an iframe".

If I'm understanding this correctly, check50 should fail a solution that does not check for the presence of <iframe ... ></iframe>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant