-
Notifications
You must be signed in to change notification settings - Fork 974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CONTINUE node in the cfg #2047
Conversation
fixes #1326. Now continue node for every kind of loops is attached to its if_loop |
tests/e2e/solc_parsing/test_data/expected/continue-all.sol-0.4.0-compact.json
Outdated
Show resolved
Hide resolved
709d5e9
to
0de7a25
Compare
@Tiko7454 can you update the solc parsing tests so they pass? You have to run this command |
Important Auto Review SkippedAuto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
@smonicas I have updated the tests and have fixed merge conflicts |
@Tiko7454 Great work on this! Thanks |
The CONTINUE node in the cfg now points to the IFLOOP node in case of a while and to the increment expression in case of a for
fixes #1326 and #435