-
Notifications
You must be signed in to change notification settings - Fork 341
Add bad use of tx.origin #23
Comments
Issue Status: 1. Open 2. Started 3. Submitted 4. Done This issue now has a funding of 100.0 DAI (100.0 USD @ $1.0/DAI) attached to it as part of the Ethereum Community Fund via ECF Web 3.0 Infrastructure Fund fund__.__
|
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Work has been started. These users each claimed they can complete the work by 7 months from now. 1) adamskrodzki has been approved to start work. I will fork repository and example of wallet using tx.origin "Authorisation" and write the attacker smart contract and also smart contract that deploys both and allow for attack Learn more on the Gitcoin Issue Details page. |
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Work for 100.0 DAI (100.0 USD @ $1.0/DAI) has been submitted by: @mkosowsk please take a look at the submitted work:
|
@montyly you have a submission! Please take a few minutes to review. |
Hi, sorry for the late reply. The PR looks good, I added a small feedback to it. |
Issue Status: 1. Open 2. Started 3. Submitted 4. Done The funding of 100.0 DAI (100.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @adamskrodzki.
|
tx.origin
should not be called for authorization.See slither testcase to have examples of incorrect and legitimate usages:
https://github.com/trailofbits/slither/blob/2aea762600ebdb46798f53c7dd65ac375783c5dc/tests/tx_origin.sol
The text was updated successfully, but these errors were encountered: