Retropad buttons B and A are swapped in the OZONE frontend.

[Zoukambada]

Description

Retropad buttons B and A are swapped in the OZONE frontend.

Expected behavior

If I press Retropad button B it should act as B, and if I press A, it should act as A in the menu.

Actual behavior

Retroarch swaps buttons B and A so that makes it impossible to press the correct button and release its action according to the button icons (both in the bottom bar and port controls from core content menu). It affects not only the bottom bar legend but also the Port 1 Controls config (probably the same for other ports 2, 3, etc) and also in content menu Port 1 Controls.

Steps to reproduce the bug

1. Fresh install Retroarch pkg.
2. OZONE theme will load boot, pay attention to the bottom bar buttons (search / back / ok). It reads Back as B (CROSS in PS3), OK as A (CIRCLE in PS3).
3. Navigate through all levels of the menu. You will realize that the buttons from the bottom bar are inverted and doesn't correspond to the icons. If you press B (CROSS) it will act as OK and will enter a menu level, if you press A (CIRCLE) you will go back to the previous menu level.
4. To check if the buttons are ok in a content, I load up Genesis Plus GX core with Mega Drive / Genesis Streets of Rage 1 rom. This game title has 3 action buttons: Genesis_A, Genesis_B, Genesis_C (which corresponds respectively as Call Police Special, Punch and Jump).
5. I check the Port 1 Controls inside Content Menu, to see if it corresponds with the image buttons, it reads Genesis_A is Y, Genesis_B is B, Genesis_C is A. I check if in the game it's really what it was meant to be and it is. But as I told before, the button bar legend icons is still wrong, it's swapped.
   
6. Now if I go to the General Menu in Settings > Input > Port 1 controls, the Genesis layout is still correct. So I go back and check the settings Menu Controls > Menu Swap OK and Cancel Buttons. It's OFF, so I turn it ON to see what happens. The icons below in the bottom bar legend swapped and also the actions of the pressed buttons swapped. So it didn't fix the problem. Anyway, I will leave like this for the momement.
7. Now I go back to General Menu in Settings > Input > Port 1 controls and check if something is different. For the looks, it's alright. It looks like all buttons are the same and the game will work as intended. So I try to play again and test the buttons in game, it works.
   
8. Now, one more time I go to General Menu in Settings > Input > Port 1 controls and I will press all the 4 face buttons of my PS3 corresponding to the icons of the Retropad and check if the button numbers are the same. If they stay the same, the game will still work with the same button layout. After changing the buttons, B changed from 0 (CROSS) btn number to 8 (CIRCLE) and A changed from 8 (CIRCLE) btn to 0 (CROSS). It means that Genesis_B swapped with Genesis_C, so if I press the Punch button, it will Jump and vice-versa. I checked the game and the buttons really swapped. So I can't relly on the icons anymore, because they don't mean what they meant to be. Now, quit Retroarch.
   
9. Renamed the image button icons inside ozone\png\icons and relaunched Retroarch, nothing happened. So I renamed the folder icons to ZiconsZ to see what would happen if there were no icons, relaunched again, and nothing happened. The icons were there. I don't know if this is the correct behavior if the folder isn't found.
   
   
   

Bisect Results

I think it happened since the OZONE theme was introduced in Retroarch PS3.

Version/Commit

You can find this information under Information/System Information

• RetroArch: [version/commit]
  Retroarch 1.9.1
  Build date: Apr 12 2021

Environment information

• OS: PS3 with firmware CFW 4.88.2 EVILNAT (COBRA 8.3)​

Additional information

• The same bug occurs with other cores. So probably it's not a core bug (for example: DOSBox-SVN core from Retroarch_PSX_CE).
• The same bug happens with Retroarch 1.9.0 [xbins.org]
  Other users already reported the bug here:
• https://www.psx-place.com/threads/retroarch-psx-place-community-edition-beta-3.32272/page-7#post-274401
• https://www.psx-place.com/threads/retroarch-psx-place-community-edition-beta-3.32272/page-14#post-290501
• https://www.psx-place.com/threads/retroarch-psx-place-community-edition-beta-3.32272/page-20#post-311596
• https://www.psx-place.com/threads/retroarch-psx-place-community-edition-beta-3.32272/page-21#post-314064