Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove panics from Kyber C code #203

Closed
karthikbhargavan opened this issue Feb 19, 2024 · 1 comment · Fixed by #220
Closed

Remove panics from Kyber C code #203

karthikbhargavan opened this issue Feb 19, 2024 · 1 comment · Fixed by #220
Assignees
@franziskuskiefer @karthikbhargavan

Comments

@karthikbhargavan
Copy link
Contributor

No description provided.

@github-project-automation github-project-automation bot moved this to 🆕 New in libcrux Feb 19, 2024
@karthikbhargavan karthikbhargavan changed the title Remove panics from C code Remove panics from Kyber C code Feb 19, 2024
@karthikbhargavan
Copy link
Contributor Author

#211

This PR addresses the main remaining panic.
However, it introduces new errors in cases where the wrong state (e.g. SHAKE x2) is used in the wrong place (e.g. where SHAKE x4 is expected).

@franziskuskiefer franziskuskiefer linked a pull request Mar 12, 2024 that will close this issue
Use Init-Absorb-Squeeze* API in ML-KEM #220
Merged
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in libcrux Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@franziskuskiefer franziskuskiefer

@karthikbhargavan karthikbhargavan

Labels
None yet
Projects
libcrux
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use Init-Absorb-Squeeze* API in ML-KEM cryspen/libcrux
2 participants
@franziskuskiefer @karthikbhargavan