fix(engine) Make sub-parts of Quote visited by visitors
#1206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I succeeded in making a version that fixes the bug for F*. But I am not sure that it does the right thing for the generic printer (at least it builds correctly and doesn't break tests). |
karthikbhargavan
approved these changes
Dec 24, 2024
W95Psp
reviewed
Jan 6, 2025
W95Psp
reviewed
Jan 6, 2025
W95Psp
reviewed
Jan 6, 2025
W95Psp
requested changes
Jan 6, 2025
Thanks, everything should be good now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1196
The investigation for #1196 revealed that subparts of
Quotevariant in the AST were ignored by visitors. The easiest way to change that is to use aquote_contentsADT inside instead of an inlined polymorphic variants. This involves quite a few changes here and there.