Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add known test directories as TestDefinition instances #17

Open
simleo opened this issue Oct 28, 2022 · 2 comments
Open

Add known test directories as TestDefinition instances #17

simleo opened this issue Oct 28, 2022 · 2 comments
Assignees

Comments

@simleo
Copy link
Member

simleo commented Oct 28, 2022

E.g.:

{
    "@id": ".tests",
    "@type": ["Dataset", "TestDefinition"],
}

This is useful information even if it's not actionable. We need to relax the "A test definition MUST refer to the test engine it is written for via conformsTo and to the engine’s version via engineVersion" requirement in the spec though.

@ilveroluca
Copy link
Member

I can look into this for snakemake

@ilveroluca ilveroluca self-assigned this Oct 28, 2022
@simleo
Copy link
Member Author

simleo commented Nov 2, 2022

We must make sure that LM is prepared for these changes before we start building these "new" crates.

I'm also wondering whether we need a "composite dataset" for the general case where tests for a workflow might consist of a mix of files and directories. In this case, though, I think we can avoid that complication by simply specifying that definition in TestSuite can point to multiple files / directories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants