Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catch exception when reading/writing from/to KV #54

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

blotus
Copy link
Member

@blotus blotus commented Dec 23, 2024

Fix #53

@shindouj
Copy link

@LaurenceJJones Is there an ETA for merging these changes? This issue just bombed my homelab in the most unexpected moment.

@LaurenceJJones
Copy link
Contributor

LaurenceJJones commented Dec 29, 2024

@LaurenceJJones Is there an ETA for merging these changes? This issue just bombed my homelab in the most unexpected moment.

We need to test the changes, how do you currently deploy the remediation?

@shindouj
Copy link

We need to test the changes, how do you currently deploy the remediation?

The self-hosted part runs in Docker for me, and Workers are usually deployed by that part. I took the liberty of deploying the remediation worker code manually and it seems to be handling the KV errors gracefully now:

IivzL5

Before it would spit out a ton of 11xx Worker errors for any request stemming from uncaught exceptions, so I call that a win.

@LaurenceJJones
Copy link
Contributor

Was going to be my exact response was pull down the code and manually create the docker image if you were running via docker. So at least we know the code does work as intended 😅

@shindouj
Copy link

Well, what I did was a little bit more limited (I just deployed the Worker changes with the old Docker image), but no worries 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KV limit exceeded cause uncaught exeception
3 participants